fix(chart/backups): normalize S3 endpoint scheme — close CN parity Bug #4 (Slice 12.4)
awscli --endpoint-url rejects bare hostnames ("scheme is missing").
Tower's migrate path emitted bare s3-cn-gd.ufileos.com for CN
tenants, which booted every scheduled backup pod into Error within
seconds. Chart-side fix: prepend https:// when missing, resilient
to either shape. Bumped 0.1.12 -> 0.1.13.
Render-tested both shapes:
endpoint: s3-cn-gd.ufileos.com -> "https://s3-cn-gd.ufileos.com"
endpoint: https://s3.amazonaws.com -> "https://s3.amazonaws.com"
This commit is contained in:
@@ -5,7 +5,7 @@ description: |
|
||||
Variation between instances is expressed via values.yaml only.
|
||||
No chart variants. No string-templating in Tower.
|
||||
type: application
|
||||
version: 0.1.12
|
||||
version: 0.1.13
|
||||
appVersion: "1.0"
|
||||
keywords:
|
||||
- odoo
|
||||
|
||||
@@ -103,7 +103,15 @@ spec:
|
||||
name: {{ .Values.backups.credentialsSecret }}
|
||||
key: AWS_SECRET_ACCESS_KEY
|
||||
- name: S3_ENDPOINT
|
||||
value: {{ .Values.backups.s3.endpoint | quote }}
|
||||
# Normalize: awscli's --endpoint-url requires a scheme
|
||||
# ("scheme is missing. Must be of the form http://...").
|
||||
# Tower's migrate path historically emitted bare
|
||||
# `s3-cn-gd.ufileos.com` for CN tenants, which booted
|
||||
# every backup pod into Error within seconds. Prepend
|
||||
# https:// when the operator-supplied value omits a
|
||||
# scheme so the chart is resilient to either shape.
|
||||
# Closes docs/architecture/2026-05-27-migrate-cn-parity.md Bug #4.
|
||||
value: {{ if hasPrefix "http" .Values.backups.s3.endpoint }}{{ .Values.backups.s3.endpoint | quote }}{{ else }}{{ printf "https://%s" .Values.backups.s3.endpoint | quote }}{{ end }}
|
||||
- name: AWS_DEFAULT_REGION
|
||||
value: {{ .Values.backups.s3.region | quote }}
|
||||
- name: S3_BUCKET
|
||||
|
||||
Reference in New Issue
Block a user